Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
akrieger
force-pushed
the
main
branch
2 times, most recently
from
9faca7b to
55b7089
Compare
akrieger
force-pushed
the
main
branch
2 times, most recently
from
9a7c6cc to
55637c4
Compare
Comment on lines
4
to
14
|
|
||
| #include <map> | ||
| #include <string> | ||
| #include <vector> | ||
| #include <string_view> | ||
| #include <set> | ||
| #include <utility> | ||
| #include <filesystem> | ||
|
|
||
| bool play_videogame( const std::string &function_name, | ||
| std::map<std::string, std::string> &game_data, |
There was a problem hiding this comment.
IWYU
Suggested change
| #include <map> | |
| #include <string> | |
| #include <vector> | |
| #include <string_view> | |
| #include <set> | |
| #include <utility> | |
| #include <filesystem> | |
| bool play_videogame( const std::string &function_name, | |
| std::map<std::string, std::string> &game_data, | |
| #include <map> | |
| #include <string> | |
| bool play_videogame( const std::string &function_name, | |
| std::map<std::string, std::string> &game_data, |
Comment on lines
4
to
10
| "type": "event_statistic", | ||
| "stat_type": "last_value", | ||
| "event_type": "game_avatar_new", | ||
| "field": "avatar_id" | ||
| "field": "avatar_id" | ||
| }, | ||
| { | ||
| "id": "last_words", |
There was a problem hiding this comment.
Suggested change
| "type": "event_statistic", | |
| "stat_type": "last_value", | |
| "event_type": "game_avatar_new", | |
| "field": "avatar_id" | |
| "field": "avatar_id" | |
| }, | |
| { | |
| "id": "last_words", | |
| "type": "event_statistic", | |
| "stat_type": "last_value", | |
| "event_type": "game_avatar_new", | |
| "field": "avatar_id" | |
| }, | |
| { | |
| "id": "last_words", |
Comment on lines
115
to
121
| // Data is always relative to itself. Also, the base path might not be writeable. | ||
| datadir_path_value = cata_path{ cata_path::root_path::data, std::filesystem::path{} }; | ||
|
|
||
| if( !base_path_value.empty() ) { | ||
| if(!base_path_value.empty()) { | ||
| #if defined(DATA_DIR_PREFIX) | ||
| datadir_value = base_path_value + "share/cataclysm-dda/"; | ||
| prefix = datadir_value; |
There was a problem hiding this comment.
Suggested change
| // Data is always relative to itself. Also, the base path might not be writeable. | |
| datadir_path_value = cata_path{ cata_path::root_path::data, std::filesystem::path{} }; | |
| if( !base_path_value.empty() ) { | |
| if(!base_path_value.empty()) { | |
| #if defined(DATA_DIR_PREFIX) | |
| datadir_value = base_path_value + "share/cataclysm-dda/"; | |
| prefix = datadir_value; | |
| // Data is always relative to itself. Also, the base path might not be writeable. | |
| datadir_path_value = cata_path{ cata_path::root_path::data, std::filesystem::path{} }; | |
| if( !base_path_value.empty() ) { | |
| #if defined(DATA_DIR_PREFIX) | |
| datadir_value = base_path_value + "share/cataclysm-dda/"; | |
| prefix = datadir_value; |
Comment on lines
4
to
14
|
|
||
| #include <map> | ||
| #include <string> | ||
| #include <vector> | ||
| #include <string_view> | ||
| #include <set> | ||
| #include <utility> | ||
| #include <filesystem> | ||
|
|
||
| bool play_videogame( const std::string &function_name, | ||
| std::map<std::string, std::string> &game_data, |
There was a problem hiding this comment.
Suggested change
| #include <map> | |
| #include <string> | |
| #include <vector> | |
| #include <string_view> | |
| #include <set> | |
| #include <utility> | |
| #include <filesystem> | |
| bool play_videogame( const std::string &function_name, | |
| std::map<std::string, std::string> &game_data, | |
| #include <map> | |
| #include <string> | |
| bool play_videogame( const std::string &function_name, | |
| std::map<std::string, std::string> &game_data, |
| "stat_type": "last_value", | ||
| "event_type": "game_avatar_new", | ||
| "field": "avatar_id" | ||
| "field": "avatar_id" |
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
Suggested change
| "field": "avatar_id" | |
| "field": "avatar_id" |
| datadir_path_value = cata_path{ cata_path::root_path::data, std::filesystem::path{} }; | ||
|
|
||
| if( !base_path_value.empty() ) { | ||
| if(!base_path_value.empty()) { |
There was a problem hiding this comment.
[JSON & C++ formatters] reported by reviewdog 🐶
Suggested change
| if(!base_path_value.empty()) { | |
| if( !base_path_value.empty() ) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Category "Brief description"
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context